voonhous commented on code in PR #18923: URL: https://github.com/apache/hudi/pull/18923#discussion_r3854359473
########## hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRowReaderContext.scala: ########## @@ -86,6 +87,14 @@ class SparkFileFormatInternalRowReaderContext(baseFileReader: SparkColumnarFileR // For each field of `target`, replace its dataType with the matching field's projected // variant struct from `source` (when present). Non-matching fields pass through. + // Review Comment: Moved the rationale onto the `sparkRequiredSchema` constructor parameter doc (the first place a reader meets the field); the comment above `overlayVariantProjections` now just points there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
