fhan688 commented on code in PR #19948:
URL: https://github.com/apache/hudi/pull/19948#discussion_r4056406710
##########
hudi-common/src/main/java/org/apache/hudi/core/read/BaseHoodieTableFileIndex.java:
##########
@@ -429,6 +430,9 @@ protected List<PartitionPath>
listPartitionPaths(List<String> relativePartitionP
}
private boolean isBeforeTimelineStarts() {
+ if
(START_COMMIT_EARLIEST.equalsIgnoreCase(incrementalQueryStartTime.get())) {
Review Comment:
> `isBeforeTimelineStarts` means the start insant might be archived, the
semantics does not equal to reading from earliest.
Good point. earliest is a sentinel rather than an instant before the active
timeline. I’ll keep the special handling but move it out of
`isBeforeTimelineStarts`, so the method retains its original semantics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
