hudi-agent commented on code in PR #19855:
URL: https://github.com/apache/hudi/pull/19855#discussion_r4078842458
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchemaUtils.java:
##########
@@ -506,18 +506,55 @@ public static HoodieSchema
generateProjectionSchema(HoodieSchema originalSchema,
Map<String, HoodieSchemaField> schemaFieldsMap =
originalSchema.getFields().stream()
.map(r -> Pair.of(r.name().toLowerCase(Locale.ROOT), r))
.collect(Collectors.toMap(Pair::getLeft, Pair::getRight));
+
+ return generateProjectionSchema(originalSchema, schemaFieldsMap,
fieldNames);
Review Comment:
🤖 Small behaviour delta from the delegation: this path used to build the
record with `createRecord(name, namespace, doc, fields)` (isError hardcoded
false), whereas the callee now uses `writeSchema.isError()`. Intentional? It
looks more correct, just confirming it's deliberate rather than a side effect
of collapsing the two implementations.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
