yihua commented on code in PR #666:
URL: https://github.com/apache/hudi-rs/pull/666#discussion_r4406667406
##########
crates/core/src/config/table.rs:
##########
@@ -175,6 +181,7 @@ impl AsRef<str> for HudiTableConfig {
Self::TimelineHistoryPath => "hoodie.timeline.history.path",
Self::MetadataTableEnabled => "hoodie.metadata.enable",
Self::MetadataTablePartitions =>
"hoodie.table.metadata.partitions",
+ Self::RecordIndexEnabled => "hoodie.metadata.record.index.enable",
Review Comment:
This should use the new config key:
`[hoodie.metadata.global.record.level.index.enable](https://hudi.apache.org/docs/configurations#hoodiemetadataglobalrecordlevelindexenable)`
from the write config.
##########
crates/core/src/config/table.rs:
##########
@@ -145,6 +145,12 @@ pub enum HudiTableConfig {
/// When creating a metadata table instance, this value should be passed
as the
/// PartitionFields option.
MetadataTablePartitions,
+
+ /// Enable the metadata-table record-level index (RLI) used to tag
upsert/delete keys.
+ ///
+ /// When false, writers fall back to [`crate::index::SimpleIndex`] (full
table scan).
+ /// Requires [`Self::MetadataTableEnabled`].
+ RecordIndexEnabled,
Review Comment:
Should this be inferred through `MetadataTablePartitions` instead of having
an independent field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
