yihua commented on code in PR #666:
URL: https://github.com/apache/hudi-rs/pull/666#discussion_r4407284030
##########
crates/core/src/lib.rs:
##########
@@ -46,12 +46,17 @@
//! }
//! ```
+// The write-path async fns (e.g. `Table::delete_keys`) nest deeply enough
that computing their
+// layout exceeds the default limit of 128 on Linux targets.
+#![recursion_limit = "256"]
+
Review Comment:
We should revisit why the nesting is deep.
##########
crates/core/src/metadata/commit.rs:
##########
@@ -193,21 +208,6 @@ impl HoodieCommitMetadata {
.unwrap_or_default()
}
- /// Get the file IDs to be replaced for a specific partition
- pub fn get_partition_replace_file_ids(&self, partition: &str) ->
Option<&Vec<String>> {
Review Comment:
nit: should we keep the replaced file ID info and relevant tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
