voonhous opened a new pull request, #20473:
URL: https://github.com/apache/hudi/pull/20473

   ### Describe the issue this Pull Request addresses
   
   Two PRs that each pass CI can still break master together, since nothing 
re-tests them against the master they land on. A merge queue fixes that, but 
needs one required check reporting on every PR and queue group; today's Java CI 
is two path-filtered workflows, so neither can hold one.
   
   Part of #20471 (and #19612). The queue itself is turned on in a follow-up 
`.asf.yaml` PR, once this one has shown `Required Checks` reporting.
   
   ### Summary and Changelog
   
   Java CI now runs through one workflow, `ci.yml`, which is ready for 
`merge_group` events.
   
   - `ci.yml` owns the triggers (pull_request, merge_group, push, 
workflow_dispatch) and calls `bot.yml` and `java_ci_engines.yml` as reusable 
workflows. Their jobs are unchanged.
   - New `Required Checks` job: reports on every PR and queue run, fails unless 
both called workflows succeed (a skip fails it too).
   - Only push keeps the path filter: a required check must report on every PR, 
and a selector job would bring back the second runner wait #19890 removed.
   
   <details>
   <summary>Smaller changes</summary>
   
   - Concurrency moves to `ci.yml`. A called workflow sees its caller's name in 
`github.workflow`, so the two files would have shared one group. Pushes are 
keyed by SHA, so a burst of queue merges never replaces a pending master run; 
only PR runs cancel in progress.
   - Codecov steps skip merge_group runs: a queue ref would file coverage under 
master for a commit that may never land.
   - `validate_source.yml` also reports on merge_group and never cancels queue 
runs.
   - README badge points at `ci.yml`; `.github/workflows/README.md` updated.
   </details>
   
   ### Impact
   
   - Check names become `CI / Java CI / <job>` and `CI / Java CI Engines / 
<job>`; none is required today.
   - Docs-only PRs run the full suite. Fork CI (the next part of #20471) moves 
fork PR runs off ASF runners.
   
   ### Risk Level
   
   low. No job body changes apart from the Codecov conditions, and nothing 
required changes until the `.asf.yaml` follow-up.
   
   ### Documentation Update
   
   none (`.github/workflows/README.md` updated)
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to