wombatu-kun commented on code in PR #20473: URL: https://github.com/apache/hudi/pull/20473#discussion_r4419791889
########## .github/workflows/ci.yml: ########## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: CI + +# The `paths` filter below applies to push only. pull_request and merge_group runs must always +# report the `Required Checks` aggregate: GitHub evaluates `paths` before creating any job, so a +# workflow skipped by the filter never reports its checks, and a required check that never reports +# stays pending forever. A docs-only PR therefore runs the full suite. The filter replaced a former +# `changes` job that listed the changed files; every test job waited on it through `needs`, which +# made each run wait for a shared runner twice, once for the filter and once for the tests. +# yml/yaml files are deliberately NOT ignored, unlike the old filter: docker/compose/*.yml drives +# the integration tests, several modules keep yml test resources, and the workflow files themselves +# need CI to run when they change. +on: + pull_request: + branches: + - master + - 'release-*' + - branch-0.x + merge_group: + types: [checks_requested] + push: + branches: + - master + - 'release-*' + - branch-0.x + paths: + - '**' + # Listed explicitly so the filter does not depend on '**' matching dot-prefixed paths. + - '.github/**' + - '!**.bmp' + - '!**.gif' + - '!**.jpg' + - '!**.jpeg' + - '!**.md' + - '!**.pdf' + - '!**.png' + - '!**.svg' + - '!.gitignore' + workflow_dispatch: + +# A group holds one running and one pending run, and a newer pending run replaces the older one +# even when cancel-in-progress is false. Pushes are therefore keyed by SHA, so a burst of queue +# merges to master never replaces a pending master run. merge_group refs are unique per queue +# entry and only pull_request runs cancel in progress, so queue runs are never cancelled. +# event_name keeps workflow_dispatch and push runs apart. The called workflows declare no +# concurrency of their own: github.workflow there resolves to this caller's name, so both would +# share one group and cancel each other. +concurrency: + group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.pull_request.number || (github.event_name == 'push' && github.sha) || github.ref }} + cancel-in-progress: ${{ github.event_name == 'pull_request' }} + +jobs: + java-ci: + name: Java CI + uses: ./.github/workflows/bot.yml + secrets: inherit + + java-ci-engines: + name: Java CI Engines + uses: ./.github/workflows/java_ci_engines.yml Review Comment: Calling both workflows from one `CI` run puts all 18 test jobs in a single workflow run, over the [ASF Actions policy](https://infra.apache.org/github-actions-policy.html)'s SHOULD of 15 concurrent jobs per workflow, and #19892's 14-job `bot.yml` rebased onto this makes it 23, past the MUST of 20. Is that intended, or should `bot.yml` and `java_ci_engines.yml` stay top-level `pull_request`/`merge_group` workflows with one aggregate job each? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
