codope commented on code in PR #767:
URL: https://github.com/apache/hudi-rs/pull/767#discussion_r4426851643
##########
cpp/src/lib.rs:
##########
@@ -33,33 +36,156 @@ mod ffi {
type ArrowArrayStream;
}
+ /// One column predicate, `field op value`. `op` is one of `=`, `!=`, `<`,
+ /// `<=`, `>`, `>=`, `IN`, `NOT IN`; the last two take a comma-separated
+ /// `value`.
+ struct HudiFilter {
+ field: String,
+ op: String,
+ value: String,
+ }
+
+ /// Options for one read. An empty `projection` reads every column;
+ /// `hudi_options` are `key=value` read configs such as
+ /// `hoodie.read.use.read_optimized.mode=true`.
+ struct HudiReadOptions {
+ projection: Vec<String>,
+ filters: Vec<HudiFilter>,
+ hudi_options: Vec<String>,
Review Comment:
agreed.. replaced it with `bool read_optimized`, since a per-read toggle on
a shared reader is the use case (one reader per table across many splits).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]