codope commented on code in PR #767:
URL: https://github.com/apache/hudi-rs/pull/767#discussion_r4426867029
##########
cpp/src/lib.rs:
##########
@@ -33,33 +36,156 @@ mod ffi {
type ArrowArrayStream;
}
+ /// One column predicate, `field op value`. `op` is one of `=`, `!=`, `<`,
+ /// `<=`, `>`, `>=`, `IN`, `NOT IN`; the last two take a comma-separated
+ /// `value`.
+ struct HudiFilter {
+ field: String,
+ op: String,
+ value: String,
+ }
+
+ /// Options for one read. An empty `projection` reads every column;
+ /// `hudi_options` are `key=value` read configs such as
Review Comment:
Good catch! the commit-time window comes from the reader's configs, so a
per-read `as.of`/`start`/`end` was accepted and ignored. With the field now a
`bool read_optimized` (see the next thread), there's no way to pass those per
read anymore, and the struct doc points time-window options to
`new_file_group_reader_with_options`. I've also corrected the "for free" line
in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
