codope opened a new pull request, #942:
URL: https://github.com/apache/hudi-rs/pull/942
### Description
`new_file_group_reader_with_options` dropped any option without `=`, so a
C++ caller who wrote `hoodie.read.use.read_optimized.mode` without a value, or
mistyped the separator, got a reader that silently ignored the option. It now
throws `rust::Error` naming the malformed option; the header doc says so.
Behavior change for C++ callers: an option without `=` used to be dropped
and is now an error. Split out of #767 at review so it shows up on its own in
the release notes.
Values may contain `=`: only the first one splits (`b=x=y` → `("b", "x=y")`).
### How are the changes test-covered
- [ ] N/A
- [x] Automated tests (unit and/or integration tests)
- [ ] Manual tests
- [ ] Details are described below
Unit test on the `key=value` parser the constructor uses (malformed option
is an error; a value containing `=` keeps it). The constructor itself can't be
handed such an option from a Rust test, because `CxxVector<CxxString>` cannot
be filled from Rust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
