pengzhiwei2018 commented on a change in pull request #2645:
URL: https://github.com/apache/hudi/pull/2645#discussion_r618317906
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/execution/HoodieLazyInsertIterable.java
##########
@@ -96,9 +97,14 @@ public HoodieInsertValueGenResult(T record, Schema schema) {
* Transformer function to help transform a HoodieRecord. This transformer
is used by BufferedIterator to offload some
* expensive operations of transformation to the reader thread.
*/
+ static <T extends HoodieRecordPayload> Function<HoodieRecord<T>,
HoodieInsertValueGenResult<HoodieRecord>> getTransformFunction(
+ Schema schema, HoodieWriteConfig config) {
+ return hoodieRecord -> new HoodieInsertValueGenResult(hoodieRecord,
schema, config.getProps());
+ }
+
static <T extends HoodieRecordPayload> Function<HoodieRecord<T>,
HoodieInsertValueGenResult<HoodieRecord>> getTransformFunction(
Schema schema) {
- return hoodieRecord -> new HoodieInsertValueGenResult(hoodieRecord,
schema);
+ return hoodieRecord -> new HoodieInsertValueGenResult(hoodieRecord,
schema, new Properties());
Review comment:
Good suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
