pengzhiwei2018 commented on a change in pull request #2645:
URL: https://github.com/apache/hudi/pull/2645#discussion_r618328717
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java
##########
@@ -63,14 +62,14 @@
public HoodieCreateHandle(HoodieWriteConfig config, String instantTime,
HoodieTable<T, I, K, O> hoodieTable,
String partitionPath, String fileId,
TaskContextSupplier taskContextSupplier) {
- this(config, instantTime, hoodieTable, partitionPath, fileId,
getWriterSchemaIncludingAndExcludingMetadataPair(config),
+ this(config, instantTime, hoodieTable, partitionPath, fileId,
Option.empty(),
taskContextSupplier);
}
public HoodieCreateHandle(HoodieWriteConfig config, String instantTime,
HoodieTable<T, I, K, O> hoodieTable,
- String partitionPath, String fileId, Pair<Schema,
Schema> writerSchemaIncludingAndExcludingMetadataPair,
+ String partitionPath, String fileId,
Option<Schema> specifySchema,
Review comment:
Yes, thanks for correct me the spell issue. The `specifiedSchema` is
used for `HoodieBootstrapHandle` to pass it is `writeSchema`, For other
Handler, it is alway be `None`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
