pengzhiwei2018 commented on a change in pull request #2645:
URL: https://github.com/apache/hudi/pull/2645#discussion_r619739911
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/execution/HoodieLazyInsertIterable.java
##########
@@ -42,6 +43,8 @@
public abstract class HoodieLazyInsertIterable<T extends HoodieRecordPayload>
extends LazyIterableIterator<HoodieRecord<T>, List<WriteStatus>> {
+ private static final Properties EMPTY_PROPERTIES = new Properties();
Review comment:
The HoodieRecordPayload#getInsertValue required a `Properties`
parameter, so here we must pass a properties object. Move the EMPTY_PROPERTIES
to `CollectionUtils` make sense to me !
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/execution/HoodieLazyInsertIterable.java
##########
@@ -42,6 +43,8 @@
public abstract class HoodieLazyInsertIterable<T extends HoodieRecordPayload>
extends LazyIterableIterator<HoodieRecord<T>, List<WriteStatus>> {
+ private static final Properties EMPTY_PROPERTIES = new Properties();
Review comment:
The HoodieRecordPayload#getInsertValue required a `Properties`
parameter, so here we must pass a properties object. Moving the
EMPTY_PROPERTIES to `CollectionUtils` make sense to me !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
