nsivabalan commented on a change in pull request #2993:
URL: https://github.com/apache/hudi/pull/2993#discussion_r642184643
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -72,8 +71,11 @@
public static final String PRECOMBINE_FIELD_PROP =
"hoodie.datasource.write.precombine.field";
public static final String WRITE_PAYLOAD_CLASS =
"hoodie.datasource.write.payload.class";
public static final String DEFAULT_WRITE_PAYLOAD_CLASS =
OverwriteWithLatestAvroPayload.class.getName();
+
public static final String KEYGENERATOR_CLASS_PROP =
"hoodie.datasource.write.keygenerator.class";
- public static final String DEFAULT_KEYGENERATOR_CLASS =
SimpleAvroKeyGenerator.class.getName();
+ public static final String KEYGENERATOR_TYPE_PROP =
"hoodie.datasource.write.keygenerator.type";
+ public static final String DEFAULT_KEYGENERATOR_TYPE = "simple";
Review comment:
oops, missed something. you can't deprecate the old config. user defined
key gen will be derived from the same config.
So, what we could do is that.
check if KEYGENERATOR_TYPE_PROP is set. // there is no default for
KEYGENERATOR_TYPE_PROP
else use value from KEYGENERATOR_CLASS_PROP.
KEYGENERATOR_CLASS_PROP can have a default of SIMPLE key gen.
Let me know if this would work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
