sbernauer commented on a change in pull request #3111:
URL: https://github.com/apache/hudi/pull/3111#discussion_r658093617
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -176,7 +176,9 @@ public KafkaOffsetGen(TypedProperties props) {
props.keySet().stream().filter(prop -> {
// In order to prevent printing unnecessary warn logs, here filter out
the hoodie
// configuration items before passing to kafkaParams
- return !prop.toString().startsWith("hoodie.");
+ return !prop.toString().startsWith("hoodie.")
+ // We need to pass some properties to kafka client so that
KafkaAvroSchemaDeserializer can use it
+ ||
prop.toString().startsWith("hoodie.deltastreamer.source.kafka.value.deserializer.");
Review comment:
This expression must currently match two settings:
`hoodie.deltastreamer.source.kafka.value.deserializer.class`
and
`hoodie.deltastreamer.source.kafka.value.deserializer.schema`
So we ether list all the settings (may be more than two in the future) which
is error-prone or we use the prefix here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
