vinothchandar commented on a change in pull request #3111:
URL: https://github.com/apache/hudi/pull/3111#discussion_r658274376
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -176,7 +176,9 @@ public KafkaOffsetGen(TypedProperties props) {
props.keySet().stream().filter(prop -> {
// In order to prevent printing unnecessary warn logs, here filter out
the hoodie
// configuration items before passing to kafkaParams
- return !prop.toString().startsWith("hoodie.");
+ return !prop.toString().startsWith("hoodie.")
+ // We need to pass some properties to kafka client so that
KafkaAvroSchemaDeserializer can use it
+ ||
prop.toString().startsWith("hoodie.deltastreamer.source.kafka.value.deserializer.");
Review comment:
understood. my point was to pull these into static final string
constants. So its easy to trace if more places start using them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
