yanghua commented on a change in pull request #3223: URL: https://github.com/apache/hudi/pull/3223#discussion_r663883851
########## File path: hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java ########## @@ -659,8 +659,8 @@ private void flushRemaining(boolean isEndInput) { .taskID(taskID) .instantTime(currentInstant) .writeStatus(writeStatus) - .isLastBatch(true) - .isEndInput(isEndInput) + .lastBatch(true) + .endInput(isEndInput) Review comment: I mean, you removed all the prefix "is" of the "isEndInput" from the repository except the getter of `WriteMetadataEvent`. So, why not change this variable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org