danny0405 commented on a change in pull request #3223: URL: https://github.com/apache/hudi/pull/3223#discussion_r663895499
########## File path: hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteFunction.java ########## @@ -659,8 +659,8 @@ private void flushRemaining(boolean isEndInput) { .taskID(taskID) .instantTime(currentInstant) .writeStatus(writeStatus) - .isLastBatch(true) - .isEndInput(isEndInput) + .lastBatch(true) + .endInput(isEndInput) Review comment: Because `WriteMetadataEvent` is a POJO, we should respect the name pattern of the POJO, while there is no need to change for `StreamWriteFunction`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org