codope commented on a change in pull request #3250: URL: https://github.com/apache/hudi/pull/3250#discussion_r667092538
########## File path: hudi-client/hudi-client-common/src/test/java/org/apache/hudi/config/TestHoodieWriteConfig.java ########## @@ -43,6 +43,7 @@ public void testPropertyLoading() throws IOException { params.put(HoodieCompactionConfig.CLEANER_COMMITS_RETAINED_PROP.key(), "1"); params.put(HoodieCompactionConfig.MAX_COMMITS_TO_KEEP_PROP.key(), "5"); params.put(HoodieCompactionConfig.MIN_COMMITS_TO_KEEP_PROP.key(), "2"); + params.put("hoodie.avro.schema.externalTransformation", "true"); Review comment: We can but that would have passed even without the fix. I thought to put what users would actually put in props file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org