zhedoubushishi commented on a change in pull request #3486:
URL: https://github.com/apache/hudi/pull/3486#discussion_r744317782
##########
File path: packaging/hudi-flink-bundle/pom.xml
##########
@@ -149,6 +150,10 @@
<include>org.apache.hbase:hbase-protocol</include>
<include>org.apache.htrace:htrace-core</include>
<include>commons-codec:commons-codec</include>
+
Review comment:
> @umehrot2 just one comment on avoiding the `hoodie-aws` dependency in
`client-common`. otherwise LGTM given you have already tested this out e2e. let
me know what you and @zhedoubushishi think
```HoodieWriteConfig``` is located in ```client-common```, I added
```HoodeAWSConfig``` there:
```
writeConfig.setDefaultOnCondition(!isAWSConfigSet,
HoodieAWSConfig.newBuilder().fromProperties(writeConfig.getProps()).build());
```
That's the reason why ```client-common``` is depend on ```hudi-aws```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
