zhedoubushishi commented on a change in pull request #3486:
URL: https://github.com/apache/hudi/pull/3486#discussion_r744317782
##########
File path: packaging/hudi-flink-bundle/pom.xml
##########
@@ -149,6 +150,10 @@
<include>org.apache.hbase:hbase-protocol</include>
<include>org.apache.htrace:htrace-core</include>
<include>commons-codec:commons-codec</include>
+
Review comment:
> @umehrot2 just one comment on avoiding the `hoodie-aws` dependency in
`client-common`. otherwise LGTM given you have already tested this out e2e. let
me know what you and @zhedoubushishi think
```HoodieWriteConfig``` is located in ```client-common```, I added
```HoodeAWSConfig``` there:
```
writeConfig.setDefaultOnCondition(!isAWSConfigSet,
HoodieAWSConfig.newBuilder().fromProperties(writeConfig.getProps()).build());
```
That's the reason why ```client-common``` depends on ```hudi-aws```.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java
##########
@@ -35,6 +38,13 @@
import static
org.apache.hudi.common.config.LockConfiguration.DEFAULT_LOCK_ACQUIRE_RETRY_WAIT_TIME_IN_MILLIS;
import static
org.apache.hudi.common.config.LockConfiguration.DEFAULT_ZK_CONNECTION_TIMEOUT_MS;
import static
org.apache.hudi.common.config.LockConfiguration.DEFAULT_ZK_SESSION_TIMEOUT_MS;
+import static
org.apache.hudi.common.config.LockConfiguration.DYNAMODB_LOCK_BILLING_MODE_PROP_KEY;
Review comment:
This part of code depends on ```HoodieWriteConfig```:
```
public static final ConfigProperty<String> DYNAMODB_LOCK_PARTITION_KEY =
ConfigProperty
.key(DYNAMODB_BASED_LOCK_PROPERTY_PREFIX + "partition_key")
.noDefaultValue()
.withInferFunction(cfg -> {
if (cfg.contains(HoodieWriteConfig.TBL_NAME)) {
return
Option.of(cfg.getString(HoodieWriteConfig.TBL_NAME));
}
return Option.empty();
})
.withDocumentation("For DynamoDB based lock provider, the
partition key for the DynamoDB lock table. "
+ "Each Hudi dataset should has it's unique key so
concurrent writers could refer to the same partition key."
+ " By default we use the Hudi table name specified to
be the partition key");
```
So I didn't move it to ```hoodie-aws```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
