danny0405 commented on a change in pull request #4336:
URL: https://github.com/apache/hudi/pull/4336#discussion_r772953860



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -706,7 +706,20 @@ protected void 
compactIfNecessary(AbstractHoodieWriteClient writeClient, String
     }
   }
 
-  protected void doClean(AbstractHoodieWriteClient writeClient, String 
instantTime) {
+  protected void cleanIfNecessary(AbstractHoodieWriteClient writeClient, 
String instantTime) {
+    Option<HoodieInstant> lastCompletedCompactionInstant = 
metadataMetaClient.reloadActiveTimeline()

Review comment:
       Agree, where should i put the util method ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to