danny0405 commented on a change in pull request #4336:
URL: https://github.com/apache/hudi/pull/4336#discussion_r773696840
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -706,7 +706,20 @@ protected void
compactIfNecessary(AbstractHoodieWriteClient writeClient, String
}
}
- protected void doClean(AbstractHoodieWriteClient writeClient, String
instantTime) {
+ protected void cleanIfNecessary(AbstractHoodieWriteClient writeClient,
String instantTime) {
+ Option<HoodieInstant> lastCompletedCompactionInstant =
metadataMetaClient.reloadActiveTimeline()
Review comment:
> reloadActiveTimeline() seems to be called right before calling this
function
Don't think so, we should still reload the timeline if there are inline
compaction triggers and completes.
> check if HoodieTableMetadata already has this function
`HoodieTableMetadata` has this function but just like it name says, it is a
metadata reader while the logic is in writer now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
