javeme commented on code in PR #1896:
URL:
https://github.com/apache/incubator-hugegraph/pull/1896#discussion_r889829625
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java:
##########
@@ -83,7 +80,7 @@ public default void setup(final Map<String, Object> config) {
}
@Override
- public default User authenticate(final Map<String, String> credentials)
+ default User authenticate(final Map<String, String> credentials)
Review Comment:
also update alignment
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/rpc/RpcServiceConfig4Server.java:
##########
@@ -21,12 +21,12 @@
public interface RpcServiceConfig4Server {
- public <T, S extends T> String addService(Class<T> clazz, S serviceImpl);
+ <T, S extends T> String addService(Class<T> clazz, S serviceImpl);
- public <T, S extends T> String addService(String graph,
+ <T, S extends T> String addService(String graph,
Review Comment:
update alignment
##########
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStore.java:
##########
@@ -816,11 +816,11 @@ private final List<Session> session() {
return list;
}
- private final Collection<RocksDBSessions> sessions() {
+ private Collection<RocksDBSessions> sessions() {
return this.dbs.values();
}
- private final void parseTableDiskMapping(Map<String, String> disks,
+ private void parseTableDiskMapping(Map<String, String> disks,
Review Comment:
update alignment
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/Records.java:
##########
@@ -26,16 +26,16 @@
public interface Records {
- public void startOneLayer(boolean forward);
+ void startOneLayer(boolean forward);
- public void finishOneLayer();
+ void finishOneLayer();
- public boolean hasNextKey();
+ boolean hasNextKey();
- public Id nextKey();
+ Id nextKey();
- public PathSet findPath(Id target, Function<Id, Boolean> filter,
+ PathSet findPath(Id target, Function<Id, Boolean> filter,
Review Comment:
update alignment
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/serializer/Serializer.java:
##########
@@ -42,65 +42,61 @@
public interface Serializer {
- public String writeMap(Map<?, ?> map);
+ String writeMap(Map<?, ?> map);
- public String writeList(String label, Collection<?> list);
+ String writeList(String label, Collection<?> list);
- public String writePropertyKey(PropertyKey propertyKey);
+ String writePropertyKey(PropertyKey propertyKey);
- public String writePropertyKeys(List<PropertyKey> propertyKeys);
+ String writePropertyKeys(List<PropertyKey> propertyKeys);
- public String writeVertexLabel(VertexLabel vertexLabel);
+ String writeVertexLabel(VertexLabel vertexLabel);
- public String writeVertexLabels(List<VertexLabel> vertexLabels);
+ String writeVertexLabels(List<VertexLabel> vertexLabels);
- public String writeEdgeLabel(EdgeLabel edgeLabel);
+ String writeEdgeLabel(EdgeLabel edgeLabel);
- public String writeEdgeLabels(List<EdgeLabel> edgeLabels);
+ String writeEdgeLabels(List<EdgeLabel> edgeLabels);
- public String writeIndexlabel(IndexLabel indexLabel);
+ String writeIndexlabel(IndexLabel indexLabel);
- public String writeIndexlabels(List<IndexLabel> indexLabels);
+ String writeIndexlabels(List<IndexLabel> indexLabels);
- public String writeTaskWithSchema(SchemaElement.TaskWithSchema tws);
+ String writeTaskWithSchema(SchemaElement.TaskWithSchema tws);
- public String writeVertex(Vertex v);
+ String writeVertex(Vertex v);
- public String writeVertices(Iterator<Vertex> vertices, boolean paging);
+ String writeVertices(Iterator<Vertex> vertices, boolean paging);
- public String writeEdge(Edge e);
+ String writeEdge(Edge e);
- public String writeEdges(Iterator<Edge> edges, boolean paging);
+ String writeEdges(Iterator<Edge> edges, boolean paging);
- public String writeIds(List<Id> ids);
+ String writeIds(List<Id> ids);
- public String writeAuthElement(AuthElement elem);
+ String writeAuthElement(AuthElement elem);
- public <V extends AuthElement> String writeAuthElements(String label,
- List<V> users);
+ <V extends AuthElement> String writeAuthElements(String label, List<V>
users);
- public String writePaths(String name, Collection<HugeTraverser.Path> paths,
+ String writePaths(String name, Collection<HugeTraverser.Path> paths,
Review Comment:
please check other methods in this file
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/Aggregate.java:
##########
@@ -72,7 +72,7 @@ public static enum AggregateFunc {
private final Number defaultValue;
private final BiFunction<Number, Number, Number> merger;
- private AggregateFunc(String name, Number defaultValue,
+ AggregateFunc(String name, Number defaultValue,
Review Comment:
I mean need to update alignment
##########
hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -331,19 +331,18 @@ public long storeSize(String table) throws IOException {
/**
* Add a row record to a table
*/
- public abstract void put(String table, byte[] family, byte[] rowkey,
- Collection<BackendColumn> columns);
+ void put(String table, byte[] family, byte[] rowkey,
Collection<BackendColumn> columns);
/**
* Add a row record to a table(can be used when adding an index)
*/
- public abstract void put(String table, byte[] family,
+ void put(String table, byte[] family,
Review Comment:
update alignment and check other methods in this file
##########
hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -331,8 +331,7 @@ public long storeSize(String table) throws IOException {
/**
* Add a row record to a table
*/
- void put(String table, byte[] family, byte[] rowkey,
- Collection<BackendColumn> columns);
+ void put(String table, byte[] family, byte[] rowkey,
Collection<BackendColumn> columns);
Review Comment:
can keep 2 lines and just update alignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
