javeme commented on code in PR #1896:
URL:
https://github.com/apache/incubator-hugegraph/pull/1896#discussion_r889886088
##########
hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java:
##########
@@ -81,7 +81,8 @@ default void setup(final Map<String, Object> config) {
@Override
default User authenticate(final Map<String, String> credentials)
- throws AuthenticationException {
+ throws AuthenticationException {
Review Comment:
align with final
##########
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/Records.java:
##########
@@ -34,8 +34,8 @@ public interface Records {
Id nextKey();
- PathSet findPath(Id target, Function<Id, Boolean> filter,
- boolean all, boolean ring);
+ PathSet findPath(Id target, Function<Id, Boolean> filter, boolean all,
Review Comment:
prefer to wrap line before "boolean all"
##########
hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -331,55 +331,55 @@ public long storeSize(String table) throws IOException {
/**
* Add a row record to a table
*/
- public abstract void put(String table, byte[] family, byte[] rowkey,
- Collection<BackendColumn> columns);
+ void put(String table, byte[] family, byte[] rowkey,
+ Collection<BackendColumn> columns);
/**
* Add a row record to a table(can be used when adding an index)
*/
- public abstract void put(String table, byte[] family,
- byte[] rowkey, byte[] qualifier, byte[]
value);
+ void put(String table, byte[] family, byte[] rowkey, byte[] qualifier,
Review Comment:
prefer to wrap line before "byte[] qualifier"
##########
hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -331,55 +331,55 @@ public long storeSize(String table) throws IOException {
/**
* Add a row record to a table
*/
- public abstract void put(String table, byte[] family, byte[] rowkey,
- Collection<BackendColumn> columns);
+ void put(String table, byte[] family, byte[] rowkey,
+ Collection<BackendColumn> columns);
/**
* Add a row record to a table(can be used when adding an index)
*/
- public abstract void put(String table, byte[] family,
- byte[] rowkey, byte[] qualifier, byte[]
value);
+ void put(String table, byte[] family, byte[] rowkey, byte[] qualifier,
+ byte[] value);
/**
* Delete a record by rowkey and qualifier from a table
*/
- public default void remove(String table, byte[] family,
- byte[] rowkey, byte[] qualifier) {
+ default void remove(String table, byte[] family, byte[] rowkey,
Review Comment:
prefer to wrap line before "byte[] rowkey"
##########
hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -450,15 +450,15 @@ default R scan(String table,
/**
* Increase a counter by rowkey and qualifier to a table
*/
- long increase(String table, byte[] family,
- byte[] rowkey, byte[] qualifier, long value);
+ long increase(String table, byte[] family, byte[] rowkey,
+ byte[] qualifier, long value);
}
/**
* Session implement for HBase
*/
public class Session extends AbstractBackendSession
- implements HbaseSession<RowIterator> {
+ implements HbaseSession<RowIterator> {
Review Comment:
align with extends
##########
hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -331,55 +331,55 @@ public long storeSize(String table) throws IOException {
/**
* Add a row record to a table
*/
- public abstract void put(String table, byte[] family, byte[] rowkey,
- Collection<BackendColumn> columns);
+ void put(String table, byte[] family, byte[] rowkey,
+ Collection<BackendColumn> columns);
/**
* Add a row record to a table(can be used when adding an index)
*/
- public abstract void put(String table, byte[] family,
- byte[] rowkey, byte[] qualifier, byte[]
value);
+ void put(String table, byte[] family, byte[] rowkey, byte[] qualifier,
+ byte[] value);
/**
* Delete a record by rowkey and qualifier from a table
*/
- public default void remove(String table, byte[] family,
- byte[] rowkey, byte[] qualifier) {
+ default void remove(String table, byte[] family, byte[] rowkey,
+ byte[] qualifier) {
this.remove(table, family, rowkey, qualifier, false);
}
/**
* Delete a record by rowkey and qualifier from a table,
* just delete the latest version of the specified column if need
*/
- public void remove(String table, byte[] family, byte[] rowkey,
- byte[] qualifier, boolean latestVersion);
+ void remove(String table, byte[] family, byte[] rowkey,
+ byte[] qualifier, boolean latestVersion);
/**
* Delete a record by rowkey from a table
*/
- public void delete(String table, byte[] family, byte[] rowkey);
+ void delete(String table, byte[] family, byte[] rowkey);
/**
* Get a record by rowkey and qualifier from a table
*/
- public R get(String table, byte[] family, byte[] rowkey,
+ R get(String table, byte[] family, byte[] rowkey,
Review Comment:
missing updating
##########
hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -415,8 +416,8 @@ default R scan(String table, Set<byte[]> prefixes) {
/**
* Scan records by rowkey start and prefix from a table
*/
- default R scan(String table, byte[] startRow,
- boolean inclusiveStart, byte[] prefix) {
+ default R scan(String table, byte[] startRow, boolean inclusiveStart,
Review Comment:
prefer to wrap line before "boolean inclusiveStart"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
