javeme commented on code in PR #1896:
URL:
https://github.com/apache/incubator-hugegraph/pull/1896#discussion_r898747128
##########
hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -220,7 +220,7 @@ public boolean existsTable(String table) throws IOException
{
public void createTable(String table, List<byte[]> cfs) throws IOException
{
TableDescriptorBuilder tdb = TableDescriptorBuilder.newBuilder(
- TableName.valueOf(this.namespace, table));
+ TableName.valueOf(this.namespace, table));
Review Comment:
prefer old style
##########
hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -484,7 +483,7 @@ private int batchSize() {
}
private void checkBatchResults(Object[] results, List<Row> rows)
- throws Throwable {
+ throws Throwable {
Review Comment:
ditto
##########
hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java:
##########
@@ -231,15 +231,15 @@ public void createTable(String table, List<byte[]> cfs)
throws IOException {
}
}
- public void createPreSplitTable(String table, List<byte[]> cfs,
+ public void createPreSplitTable(String table, List<byte[]> cfs,
short numOfPartitions) throws IOException {
TableDescriptorBuilder builder = TableDescriptorBuilder.newBuilder(
TableName.valueOf(this.namespace, table));
for (byte[] cf : cfs) {
builder.setColumnFamily(ColumnFamilyDescriptorBuilder.newBuilder(cf).build());
}
byte[][] splits = new byte[numOfPartitions - 1]
-
[org.apache.hadoop.hbase.util.Bytes.SIZEOF_SHORT];
+ [org.apache.hadoop.hbase.util.Bytes.SIZEOF_SHORT];
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
