spetz commented on code in PR #2348:
URL: https://github.com/apache/iggy/pull/2348#discussion_r2528277020
##########
core/connectors/runtime/src/configs/connectors.rs:
##########
@@ -111,8 +111,20 @@ pub struct StreamProducerConfig {
}
#[async_trait]
-pub trait ConnectorsConfigProvider {
- async fn load_configs(&self) -> Result<ConnectorsConfig, RuntimeError>;
+pub trait ConnectorsConfigProvider: Send + Sync {
Review Comment:
We can also add one more function (as described previously) that would
return all existing configs versions (e.g. could be a HashMap or Vec of some
simple struct) - this would be useful for config updates checking in the
background job (much less data to transfer over the wire).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
