spetz commented on code in PR #2348:
URL: https://github.com/apache/iggy/pull/2348#discussion_r2537807832


##########
core/connectors/runtime/src/configs/connectors.rs:
##########
@@ -110,17 +174,57 @@ pub struct StreamProducerConfig {
     pub linger_time: Option<String>,
 }
 
+#[derive(Debug, Clone, Serialize, Deserialize)]
+pub struct ConnectorConfigVersionInfo {
+    pub version: u64,
+    pub created_at: DateTime<Utc>,
+}
+
+#[derive(Debug, Default, Clone, Serialize, Deserialize)]
+pub struct ConnectorConfigVersions {
+    pub sinks: HashMap<String, ConnectorConfigVersionInfo>,
+    pub sources: HashMap<String, ConnectorConfigVersionInfo>,
+}
+
 #[async_trait]
-pub trait ConnectorsConfigProvider {
-    async fn load_configs(&self) -> Result<ConnectorsConfig, RuntimeError>;
+pub trait ConnectorsConfigProvider: Send + Sync {

Review Comment:
   I think we'll need also need the delete functions to remove unused 
configurations, and that should be all :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to