mmodzelewski commented on code in PR #2348:
URL: https://github.com/apache/iggy/pull/2348#discussion_r2528551853
##########
core/connectors/runtime/src/configs/connectors.rs:
##########
@@ -111,8 +111,20 @@ pub struct StreamProducerConfig {
}
#[async_trait]
-pub trait ConnectorsConfigProvider {
- async fn load_configs(&self) -> Result<ConnectorsConfig, RuntimeError>;
+pub trait ConnectorsConfigProvider: Send + Sync {
+ async fn get_all_configs(&self) -> Result<ConnectorsConfig, RuntimeError>;
+ async fn get_sink_configs(&self, key: &str) -> Result<Vec<SinkConfig>,
RuntimeError>;
+ async fn get_sink_config(
Review Comment:
Updated. In the API version is still required though, as we need a
distinction from get all versions endpoint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
