jordigilh commented on code in PR #372:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/372#discussion_r1480376534
##########
controllers/profiles/dev/states_dev.go:
##########
@@ -70,15 +73,14 @@ func (e *ensureRunningWorkflowState) Do(ctx
context.Context, workflow *operatora
devBaseContainerImage := workflowdef.GetDefaultWorkflowDevModeImageTag()
// check if the Platform available
- pl, err := platform.GetActivePlatform(ctx, e.C, workflow.Namespace)
- if err == nil && len(pl.Spec.DevMode.BaseImage) > 0 {
- devBaseContainerImage = pl.Spec.DevMode.BaseImage
+ if plf != nil && len(plf.Spec.DevMode.BaseImage) > 0 {
+ devBaseContainerImage = plf.Spec.DevMode.BaseImage
}
userPropsCM, _, err := e.ensurers.userPropsConfigMap.Ensure(ctx,
workflow)
if err != nil {
return ctrl.Result{Requeue: false}, objs, err
}
- managedPropsCM, _, err := e.ensurers.managedPropsConfigMap.Ensure(ctx,
workflow, pl, common.ManagedPropertiesMutateVisitor(ctx,
e.StateSupport.Catalog, workflow, pl, userPropsCM.(*corev1.ConfigMap)))
+ managedPropsCM, _, err := e.ensurers.managedPropsConfigMap.Ensure(ctx,
workflow, plf, common.ManagedPropertiesMutateVisitor(ctx,
e.StateSupport.Catalog, workflow, plf, userPropsCM.(*corev1.ConfigMap)))
Review Comment:
Honestly, I don't know, perhaps it was during one of my
re-re-re-factorings... I intended to change all variables named `platform` to
avoid collision with the one package with that name, maybe I went too far here
because there was no reason for the change 😄. Do you want me to revert it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
