ricardozanini commented on code in PR #372:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/372#discussion_r1481464329
##########
controllers/profiles/dev/states_dev.go:
##########
@@ -70,15 +73,14 @@ func (e *ensureRunningWorkflowState) Do(ctx
context.Context, workflow *operatora
devBaseContainerImage := workflowdef.GetDefaultWorkflowDevModeImageTag()
// check if the Platform available
- pl, err := platform.GetActivePlatform(ctx, e.C, workflow.Namespace)
- if err == nil && len(pl.Spec.DevMode.BaseImage) > 0 {
- devBaseContainerImage = pl.Spec.DevMode.BaseImage
+ if plf != nil && len(plf.Spec.DevMode.BaseImage) > 0 {
+ devBaseContainerImage = plf.Spec.DevMode.BaseImage
}
userPropsCM, _, err := e.ensurers.userPropsConfigMap.Ensure(ctx,
workflow)
if err != nil {
return ctrl.Result{Requeue: false}, objs, err
}
- managedPropsCM, _, err := e.ensurers.managedPropsConfigMap.Ensure(ctx,
workflow, pl, common.ManagedPropertiesMutateVisitor(ctx,
e.StateSupport.Catalog, workflow, pl, userPropsCM.(*corev1.ConfigMap)))
+ managedPropsCM, _, err := e.ensurers.managedPropsConfigMap.Ensure(ctx,
workflow, plf, common.ManagedPropertiesMutateVisitor(ctx,
e.StateSupport.Catalog, workflow, plf, userPropsCM.(*corev1.ConfigMap)))
Review Comment:
No, don't need to bother unless you need to make another change in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
