ricardozanini commented on code in PR #372:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/372#discussion_r1484279710
##########
controllers/profiles/common/object_creators.go:
##########
@@ -157,7 +159,13 @@ func defaultContainer(workflow *operatorapi.SonataFlow)
(*corev1.Container, erro
if err := mergo.Merge(defaultFlowContainer,
workflow.Spec.PodTemplate.Container.ToContainer(), mergo.WithOverride); err !=
nil {
return nil, err
}
- defaultFlowContainer = ConfigurePersistence(defaultFlowContainer,
workflow.Spec.Persistence, defaultSchemaName, workflow.Namespace)
+ if workflow.Spec.Persistence != nil {
Review Comment:
@masayag @jordigilh using the attributes nil/empty/data to define if we
configure a certain feature is error-prone, leading to misconfiguration and
user misinterpretation. @masayag comment's to prove my point, he interpreted
differently from what you're proposing initially.
The `.spec.dataIndex.enabled` is different since we are forcing an `enabled`
attribute to clearly define that we opt-in/out to the feature.
In this case here, labels are well suited since we are using an enum to
validate and it clearly expresses the operator's behavior. Also, @wmedvede
@tchughesiv any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
