jordigilh commented on code in PR #372: URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/372#discussion_r1484373523
########## api/v1alpha08/sonataflow_persistence_types.go: ########## @@ -14,6 +14,32 @@ package v1alpha08 +// PlatformPersistenceOptionsSpec configures the DataBase in the platform spec. This specification can +// be used by workflows and platform services when they don't provide one of their own. +// +optional +// +kubebuilder:validation:MaxProperties=1 Review Comment: Isn´t it a new struct? The original one still remains unchanged from the API point of view. So mentioning that it doesn´t have the `databaseSchema` when it never had one sounds a bit strange to me. Maybe I'm missing something here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
