tiagobento commented on PR #2195: URL: https://github.com/apache/incubator-kie-tools/pull/2195#issuecomment-2033308256
@fantonangeli Having the parent `pom.xml` at the `examples` directory is misleading, as not all examples are parented by that `pom.xml` file. More than that, this `pom.xml` wouldn't be owned by any package in particular, making it impossible to tell, using our current setup, what to build when there's a change made to it. To successfully create this parenting mechanism inside `kie-tools`, the best way is to create a new package. Please take a look at what Pere did here #2223 with the `maven-base` package. The parenting strategy for Maven packages is not well defined yet, but I feel like the best way forward for us is having everything concentrated at the `maven-base` package, to act as a centralized place for us to manage our Maven versions. I also want to avoid a complex hierarchy between Maven packages. Flat structures FTW :) For now, though, don't worry about this Maven parent unification, so please create a new `quarkus-examples-maven-parent` package. Also, WDYT about: 1. Renaming `decisiontable-quarkus-example` to `drools-xls-decision-table-quarkus-example`; 2. Renaming `sonataflow-greeting-quarkus` to `sonataflow-greeting-quarkus-example` so we keep a consistency `[domain]-[feature/name]-quarkus-example`... cc @paulovmr @caponetto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
