fantonangeli commented on PR #2195:
URL:
https://github.com/apache/incubator-kie-tools/pull/2195#issuecomment-2033888866
Hi @tiagobento, thanks a lot for your advice and help here.
+1 about naming consistency.
+1 avoid having a pom directly in the `examples` dir.
Regarding creating a new package `quarkus-examples-maven-parent `, I don't
think we need this package to have an `env/index.js` and a `install.js` as the
children modules have it defined already.
This package doesn't also need a build configuration on a `package.json` as
the children modules have their build configuration.
So IMHO we don't need a new pnpm package but this can be just a simple dir
`examples/quarkus-examples-maven-parent ` with a pom inside.
But
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
