tiagobento commented on PR #2195: URL: https://github.com/apache/incubator-kie-tools/pull/2195#issuecomment-2034821675
@fantonangeli The only problem I see with this suggestion is in the future... let me exaplain. A directory inside `packages`/`examples`/`scripts` without a `package.json` and a clear reference to it on their dependent packages opens the precedence of "directories" becoming a concept, while we're actually aiming for the 'atom' of the KIE Tools build system to be a "package". Also, even if `examples/quarkus-examples-maven-parent` is really simple, and it really doesn't have much inside it, if we make a change to its `pom.xml` and break it, we wouldn't find out, since we wouldn't be building it. We'd only find out when building the packages that depend on it, which IMHO is not a great precedence to have too. Don't worry about repeating the `env/index.js` everywhere, it's expected to work like that, and it is really easy to make changes to it, as pretty much everything related to our` build-env` mechanism is grep-able. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
