fjtirado commented on code in PR #3572:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3572#discussion_r1681189376
##########
kogito-serverless-workflow/kogito-serverless-workflow-builder/src/main/java/org/kie/kogito/serverless/workflow/io/CachedContentLoader.java:
##########
@@ -91,10 +90,13 @@ public InputStream getInputStream() {
}
}
- protected abstract byte[] loadURI(URI uri);
-
- @Override
- public URI uri() {
- return uri;
+ protected static String trimScheme(String uri, String scheme) {
Review Comment:
Actually, although sonataflow, indirectly because jbpm-flow-builder includes
drools-.compiler, depends on drool-utils, it is not a direct dependency, so I
would prefer to keep it that way. Or at least do not make that change as part
of this PR (because to add this direct dependency will be controversial), which
is a bug fix for windows,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
