fjtirado commented on code in PR #3572:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3572#discussion_r1692638366
##########
springboot/integration-tests/pom.xml:
##########
@@ -187,6 +187,20 @@
</execution>
</executions>
</plugin>
+ <plugin>
Review Comment:
@gitgabrio you are assuming (I do not understand why) that openapi-common is
a transitive dependency of SpringBoot IT test. Thats not the case, so all your
rationale is flaw.
If you check the oklist in the compare file for the springbootit module, you
will see the quarkus jars there. That means that (as it is happening with
openapi-common) any PR modifying those files will not get green light.
When this failure is showing is that the compare procedure is faulty,
because is not comparing only the dependencies, but all JARs. Hence, the
workaroung should be to disable it, in my opinion, not to add dependencies that
do not belong to the module just to have green light in the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
