gitgabrio commented on code in PR #3572:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3572#discussion_r1690925406
##########
springboot/integration-tests/pom.xml:
##########
@@ -187,6 +187,20 @@
</execution>
</executions>
</plugin>
+ <plugin>
Review Comment:
@fjtirado
As discussed
[elsewhere](https://github.com/apache/incubator-kie-kogito-runtimes/pull/3579),
maybe we can't simply disable this comparison.
Side notes:
1. the reproducible is showing us a problem in the setup of thet test, and
removing it only hides the problem
2. the "twin" tests on kogito side are written on completely different way
(i.e. real project with unit tests, and not maven-standard it) , and this
introduce a further asymmetry
3. I think we have strive to improve the code whenever we hit a problem,
even if not strictly related to the immediate task; and IMO the two points
above are enough to need a carefull review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
