wmedvede commented on code in PR #2794:
URL:
https://github.com/apache/incubator-kie-tools/pull/2794#discussion_r1880540110
##########
packages/sonataflow-operator/internal/controller/cfg/controllers_cfg.go:
##########
@@ -45,36 +45,31 @@ var defaultControllersCfg = &ControllersCfg{
BuilderConfigMapName: "sonataflow-operator-builder-config",
}
-type GAV struct {
+type GroupArtifactId struct {
GroupId string `yaml:"groupId,omitempty"`
ArtifactId string `yaml:"artifactId,omitempty"`
- Version string `yaml:"version,omitempty"`
Review Comment:
OK, so the idea is that we remove the version from here, and at the time of
executing run_quarkus_mvn_add_extension (bla, bla), the extension number will
be taken from the kogito-version or the quarkus-version that corresponds to
current product version (just built) accordingly, right?
And the mechanism works on the basis that, to have the version auto-filling,
extensions must mandatory belong to gropups io.quarkus, org.kie, or "kogito".
This leaves out the possibility of configuring an extension that don't
belong to any of these groups right? (at least in controllers_cfg.yaml)
Also, one thing that comes to my mind. With this new mechanism (in a given
installation) it's not possible to configure the controllers config file to
point to a different version, right?
Thinking about situations where you want to quickly do something like this:
1) something is not good
2) I quickly configure the controllers config ConfigMap with a different
version ej 9.101.xxxxx, instead of 9.102.xxxxx
3) restart the operator pod, And I can quickly see if things works with the
previous version to test, etc.
##########
packages/sonataflow-operator/hack/bump-version.sh:
##########
@@ -20,20 +20,10 @@
set -e
-script_dir_path=$(dirname "${BASH_SOURCE[0]}")
-source "${script_dir_path}"/env.sh
-
imageName=$(pnpm build-env sonataFlowOperator.registry)/$(pnpm build-env
sonataFlowOperator.account)/$(pnpm build-env sonataFlowOperator.name)
imageTag=$(pnpm build-env sonataFlowOperator.buildTag)
version=$(pnpm build-env sonataFlowOperator.version)
-targetSonataflowBuilderImage=$(pnpm build-env
sonataFlowOperator.sonataflowBuilderImage)
Review Comment:
@ricardozanini If I don't remember wrong, this bump-version.sh script is
executed as part of the automations executed during the release process, to
adjust the image names to the version to be released etc.
If the image names setting is removed from this script to the make invoked
python update_controllers_cfg.py, are you sure this is also executed as part of
the automations?
Not saying this is bad, just double checking
##########
packages/sonataflow-operator/internal/controller/cfg/controllers_cfg.go:
##########
@@ -45,36 +45,31 @@ var defaultControllersCfg = &ControllersCfg{
BuilderConfigMapName: "sonataflow-operator-builder-config",
}
-type GAV struct {
+type GroupArtifactId struct {
GroupId string `yaml:"groupId,omitempty"`
ArtifactId string `yaml:"artifactId,omitempty"`
- Version string `yaml:"version,omitempty"`
Review Comment:
Maybe we can just the data structure/processing as is, and keep the version
field.
However, we don't set it anymore. So, if not set, the automatic mechanism
will be applied.
But we keep the trapdoor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
