ricardozanini commented on code in PR #2794:
URL:
https://github.com/apache/incubator-kie-tools/pull/2794#discussion_r1882840580
##########
packages/sonataflow-operator/hack/bump-version.sh:
##########
@@ -20,20 +20,10 @@
set -e
-script_dir_path=$(dirname "${BASH_SOURCE[0]}")
-source "${script_dir_path}"/env.sh
-
imageName=$(pnpm build-env sonataFlowOperator.registry)/$(pnpm build-env
sonataFlowOperator.account)/$(pnpm build-env sonataFlowOperator.name)
imageTag=$(pnpm build-env sonataFlowOperator.buildTag)
version=$(pnpm build-env sonataFlowOperator.version)
-targetSonataflowBuilderImage=$(pnpm build-env
sonataFlowOperator.sonataflowBuilderImage)
Review Comment:
@wmedvede I've removed it here because we are doing this bump in the new
Python script:
[update_controllers_cfg.py](https://github.com/apache/incubator-kie-tools/pull/2794/files#diff-5b595ecfd37c9ce765c0601d9c566a9f156680e8ac3cbc060e7f5f03069b9a70).
This script runs during the build process, guaranteeing our versioning and
image values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
