ricardozanini commented on code in PR #2794:
URL:
https://github.com/apache/incubator-kie-tools/pull/2794#discussion_r1882837925
##########
packages/sonataflow-operator/internal/controller/cfg/controllers_cfg.go:
##########
@@ -45,36 +45,31 @@ var defaultControllersCfg = &ControllersCfg{
BuilderConfigMapName: "sonataflow-operator-builder-config",
}
-type GAV struct {
+type GroupArtifactId struct {
GroupId string `yaml:"groupId,omitempty"`
ArtifactId string `yaml:"artifactId,omitempty"`
- Version string `yaml:"version,omitempty"`
Review Comment:
@wmedvede I'd rather remove for good the possibility of adding the version
since the platform will provide it. If we need to add the version to any other
future library to the `controller_cfg`, we can then create a new data structure
for it. But even in these cases, I'd rather have dependency control within the
platform.
This hack you mentioned crossed my mind (change the version to check if the
workaround works). In this case, one can use the build ARGS
`QUARKUS_EXTENSIONS` directly to the `SonataFlowBuild`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
