domhanak commented on code in PR #2819:
URL:
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1906540758
##########
packages/serverless-workflow-diagram-editor/package.json:
##########
@@ -18,11 +18,11 @@
],
"scripts": {
"build:dev": "run-script-os",
- "build:dev:linux:darwin": "mvn clean install -DskipTests -DskipITs
-Pno-showcase",
- "build:dev:win32": "pnpm powershell \"mvn clean install `-DskipTests
`-DskipITs `-Pno-showcase\"",
Review Comment:
could you please move this to separate PR? this has nothing to do with maven
plugins update. I know the profile does not exist, yet having a PR like `Fix
non-exsiting profile usage in serverless-workflow-diagram-editor` is way more
descriptive and makes this change not hidden amongst some other unrelated work.
Or remove it if possible ( not sure what enforcer settings we have...) and I
ll fix it in separate PR. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org
