jomarko commented on code in PR #6213:
URL:
https://github.com/apache/incubator-kie-drools/pull/6213#discussion_r1919856618
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/util/BooleanEvalHelper.java:
##########
@@ -179,6 +180,70 @@ public static Boolean
isEqualTimeInSemanticD(TemporalAccessor left, TemporalAcce
return result;
}
+ /**
+ * This method consider if the <code>value</code> object is a
<code>String</code>
+ * In that case, return the <code>String.equal</code> result
+ * Otherwise, default to the <code>isEqual</code>
+ * @param value
+ * @param itemFromList
+ * @return
+ */
+ public static boolean isEqualsStringCompare(Object value, Object
itemFromList) {
Review Comment:
Could we please improve this method name? I am not native english speaker,
sorry if the problem is on my side only, however, from my point of view, the
current name `isEqualsStringCompare` do not give enough information that:
- we compare strings for equality
- or we use FEELDialect logic for comparing objects
##########
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/DMNInputRuntimeBFEELTest.java:
##########
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
Review Comment:
it is minor thing, however I think we should not include similar code as
part of this PR and try to use the same withour `<p>`
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/ast/InNode.java:
##########
@@ -26,6 +26,7 @@
import org.kie.dmn.feel.runtime.Range;
import org.kie.dmn.feel.runtime.UnaryTest;
import org.kie.dmn.feel.runtime.functions.ListContainsFunction;
Review Comment:
I think this is unused now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
