jomarko commented on code in PR #6213:
URL: 
https://github.com/apache/incubator-kie-drools/pull/6213#discussion_r1920060232


##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/util/BooleanEvalHelper.java:
##########
@@ -30,6 +30,7 @@
 import java.util.Optional;
 import java.util.function.BiPredicate;
 
+import org.kie.api.io.Resource;

Review Comment:
   is this import needed?



##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/util/BooleanEvalHelper.java:
##########
@@ -179,6 +180,70 @@ public static Boolean 
isEqualTimeInSemanticD(TemporalAccessor left, TemporalAcce
         return result;
     }
 
+    /**
+     * This method consider if the <code>value</code> object is a 
<code>String</code>
+     * In that case, return the <code>String.equal</code> result
+     * Otherwise, default to the <code>isEqual</code>
+     * @param value
+     * @param itemFromList
+     * @return
+     */
+    public static boolean isEqualsStringCompare(Object value, Object 
itemFromList) {

Review Comment:
   ok, thank you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to