yesamer commented on code in PR #4241:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3085864569
##########
kogito-gradle-plugin-test/pom.xml:
##########
@@ -46,7 +46,32 @@
<dependency>
<groupId>org.kie.kogito</groupId>
<artifactId>kogito-gradle-plugin</artifactId>
- <version>${project.version}</version>
+ <exclusions>
Review Comment:
@gitgabrio Out of curiosity: Why all those exclusions are required?
##########
springboot/bom/pom.xml:
##########
@@ -19,120 +18,381 @@
under the License.
-->
-<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xmlns="http://maven.apache.org/POM/4.0.0";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
- <parent>
- <artifactId>springboot</artifactId>
- <groupId>org.kie.kogito</groupId>
- <version>999-SNAPSHOT</version>
- </parent>
- <modelVersion>4.0.0</modelVersion>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <parent>
+ <groupId>org.kie.kogito</groupId>
+ <artifactId>kogito-build-no-bom-parent</artifactId>
+ <version>999-SNAPSHOT</version>
+
<relativePath>../../kogito-build/kogito-build-no-bom-parent/pom.xml</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>kogito-spring-boot-bom</artifactId>
+ <name>Kogito :: Spring Boot :: BOM</name>
+ <description>Spring Boot descriptor for Kogito libraries and projects
based on Spring runtime.</description>
+ <packaging>pom</packaging>
+ <properties>
+ <!-- Used to define which poms are allowed to have
dependencyManagement sections. This is to enforce the convention that only the
root pom should have dependencyManagement, and all other poms should inherit
from it. -->
+
<allowedPomsList>org.kie.kogito:kogito-spring-boot-bom</allowedPomsList>
+ <version.io.swagger.core.v3>2.2.38</version.io.swagger.core.v3>
Review Comment:
@gitgabrio This version is unused.
##########
kogito-codegen-modules/kogito-codegen-decisions/pom.xml:
##########
@@ -36,24 +36,6 @@
<dependency-plugin.version>3.6.1</dependency-plugin.version>
Review Comment:
@gitgabrio Is this necessary?
##########
addons/common/pom.xml:
##########
@@ -34,6 +34,21 @@
<description>Parent Module for the base Addons Commons</description>
<packaging>pom</packaging>
+ <properties>
+ <version.mongodb-driver-sync>5.5.1</version.mongodb-driver-sync>
Review Comment:
@gitgabrio Can't we manage this in a parent bom?
##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/pom.xml:
##########
@@ -22,171 +22,174 @@
<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
- <modelVersion>4.0.0</modelVersion>
- <parent>
- <groupId>org.apache.kie.sonataflow</groupId>
- <artifactId>sonataflow-quarkus-extension</artifactId>
- <version>999-SNAPSHOT</version>
- </parent>
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.kie.sonataflow</groupId>
+ <artifactId>sonataflow-quarkus-extension</artifactId>
+ <version>999-SNAPSHOT</version>
+ </parent>
- <artifactId>sonataflow-quarkus-extension-live-reload-test</artifactId>
- <name>SonataFlow :: Quarkus Serverless Workflow Extension :: Live Reload
Tests</name>
+ <artifactId>sonataflow-quarkus-extension-live-reload-test</artifactId>
+ <name>SonataFlow :: Quarkus Serverless Workflow Extension :: Live Reload
Tests</name>
<properties>
-
<java.module.name>org.kie.kogito.quarkus.serverless.workflow.deployment.livereload</java.module.name>
+
<java.module.name>org.kie.kogito.quarkus.serverless.workflow.deployment.livereload</java.module.name>
</properties>
- <dependencies>
- <dependency>
- <groupId>org.apache.kie.sonataflow</groupId>
- <artifactId>sonataflow-quarkus</artifactId>
- </dependency>
- <dependency>
- <groupId>io.quarkus</groupId>
- <artifactId>quarkus-resteasy</artifactId>
- </dependency>
- <dependency>
- <groupId>io.quarkus</groupId>
- <artifactId>quarkus-resteasy-jackson</artifactId>
- </dependency>
- <dependency>
- <groupId>io.quarkus</groupId>
- <artifactId>quarkus-resteasy-client-oidc-filter</artifactId>
- </dependency>
- <dependency>
- <groupId>io.quarkus</groupId>
- <artifactId>quarkus-smallrye-openapi</artifactId>
- </dependency>
+ <dependencies>
+ <!--<dependency>
+ <groupId>org.jboss</groupId>
+ <artifactId>jboss-transaction-spi</artifactId>
+ </dependency>-->
Review Comment:
@gitgabrio Can we remove this?
##########
kogito-build/kogito-build-no-bom-parent/pom.xml:
##########
@@ -683,7 +665,7 @@
<goals>
<goal>highest-basedir</goal>
</goals>
- <phase>validate</phase>
+ <phase>none</phase>
Review Comment:
@gitgabrio Can you please explain this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
