gitgabrio commented on code in PR #4241:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4241#discussion_r3086145666
##########
springboot/bom/pom.xml:
##########
@@ -19,120 +18,381 @@
under the License.
-->
-<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xmlns="http://maven.apache.org/POM/4.0.0";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
- <parent>
- <artifactId>springboot</artifactId>
- <groupId>org.kie.kogito</groupId>
- <version>999-SNAPSHOT</version>
- </parent>
- <modelVersion>4.0.0</modelVersion>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <parent>
+ <groupId>org.kie.kogito</groupId>
+ <artifactId>kogito-build-no-bom-parent</artifactId>
+ <version>999-SNAPSHOT</version>
+
<relativePath>../../kogito-build/kogito-build-no-bom-parent/pom.xml</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+ <artifactId>kogito-spring-boot-bom</artifactId>
+ <name>Kogito :: Spring Boot :: BOM</name>
+ <description>Spring Boot descriptor for Kogito libraries and projects
based on Spring runtime.</description>
+ <packaging>pom</packaging>
+ <properties>
+ <!-- Used to define which poms are allowed to have
dependencyManagement sections. This is to enforce the convention that only the
root pom should have dependencyManagement, and all other poms should inherit
from it. -->
+
<allowedPomsList>org.kie.kogito:kogito-spring-boot-bom</allowedPomsList>
+ <version.io.swagger.core.v3>2.2.38</version.io.swagger.core.v3>
Review Comment:
I removed because it is the same version as declared in kie-parent.
If, by chance (e.g. framework need) the version had to be different, then it
would have to be kept even if not directly referenced in the pom or repo (more
or less same issue we discussed about inheritance and property resolution): am
I clear ? Does this make sense ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
