yesamer commented on code in PR #2317:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086446448
##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
- @Test
+ /* @Test */
void shouldReturnUnauthorized() {
given().get(TRUSTY_ENDPOINT)
.then().statusCode(HttpStatus.SC_UNAUTHORIZED);
}
- @Test
+ /* @Test */
Review Comment:
@gitgabrio Are those temporarily disabled?
##########
trusty/trusty-storage/trusty-storage-redis/pom.xml:
##########
@@ -22,18 +22,20 @@
<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xmlns="http://maven.apache.org/POM/4.0.0";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
<parent>
- <artifactId>trusty-storage</artifactId>
<groupId>org.kie.kogito</groupId>
+ <artifactId>trusty-storage</artifactId>
<version>999-SNAPSHOT</version>
</parent>
- <modelVersion>4.0.0</modelVersion>
<artifactId>trusty-storage-redis</artifactId>
<name>Kogito Apps :: Trusty Storage Redis</name>
<properties>
<java.module.name>org.kie.kogito.trusty.storage.redis</java.module.name>
+ <disable.quarkus.jar.rename>false</disable.quarkus.jar.rename>
+ <disable.quarkus.plugin>true</disable.quarkus.plugin>
Review Comment:
@gitgabrio Can you please explain those additions?
##########
trusty/trusty-storage/trusty-storage-infinispan/pom.xml:
##########
@@ -1,77 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
-
--->
-<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xmlns="http://maven.apache.org/POM/4.0.0";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
- <parent>
- <artifactId>trusty-storage</artifactId>
- <groupId>org.kie.kogito</groupId>
- <version>999-SNAPSHOT</version>
- </parent>
- <modelVersion>4.0.0</modelVersion>
-
- <artifactId>trusty-storage-infinispan</artifactId>
Review Comment:
@gitgabrio If I understood correctly, are we removing this module entirely?
##########
persistence-commons/persistence-commons-mongodb/pom.xml:
##########
@@ -34,8 +34,20 @@
<properties>
<java.module.name>org.kie.kogito.persistence.mongodb</java.module.name>
+ <version.mongodb-driver-sync>5.5.1</version.mongodb-driver-sync>
Review Comment:
@gitgabrio Don't we have a "global" mongodb declaration?
##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -55,15 +55,16 @@ class KeycloakTrustyServiceIT {
@InjectMock
TrustyService trustyService;
- @Test
+ /* @Test */
Review Comment:
@gitgabrio Are those temporarily disabled?
##########
trusty/trusty-service/trusty-service-common/src/test/java/org/kie/kogito/trusty/service/common/KeycloakTrustyServiceIT.java:
##########
@@ -22,28 +22,28 @@
import java.util.ArrayList;
import org.apache.http.HttpStatus;
-import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.api.Disabled;
import org.kie.kogito.test.quarkus.QuarkusTestProperty;
import org.kie.kogito.testcontainers.KogitoKeycloakContainer;
import org.kie.kogito.testcontainers.quarkus.KeycloakQuarkusTestResource;
import org.kie.kogito.trusty.service.common.models.MatchedExecutionHeaders;
import io.quarkus.test.InjectMock;
-import io.quarkus.test.common.QuarkusTestResource;
-import io.quarkus.test.common.ResourceArg;
-import io.quarkus.test.junit.QuarkusTest;
import static io.restassured.RestAssured.given;
-import static
org.kie.kogito.testcontainers.quarkus.KeycloakQuarkusTestResource.KOGITO_OIDC_TENANTS;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyInt;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.when;
-@QuarkusTest
-@QuarkusTestResource(value = KeycloakQuarkusTestResource.class, initArgs = {
@ResourceArg(name = KOGITO_OIDC_TENANTS, value = "web-app-tenant") })
-@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+/*@QuarkusTest
+@QuarkusTestResource(value = KeycloakQuarkusTestResource.class, initArgs = {
@ResourceArg(name = KOGITO_OIDC_TENANTS,
Review Comment:
@gitgabrio Are those temporarily disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
