gitgabrio commented on code in PR #2317: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2317#discussion_r3086528704
########## trusty/trusty-storage/trusty-storage-redis/pom.xml: ########## @@ -22,18 +22,20 @@ <project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.org/POM/4.0.0"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> <parent> - <artifactId>trusty-storage</artifactId> <groupId>org.kie.kogito</groupId> + <artifactId>trusty-storage</artifactId> <version>999-SNAPSHOT</version> </parent> - <modelVersion>4.0.0</modelVersion> <artifactId>trusty-storage-redis</artifactId> <name>Kogito Apps :: Trusty Storage Redis</name> <properties> <java.module.name>org.kie.kogito.trusty.storage.redis</java.module.name> + <disable.quarkus.jar.rename>false</disable.quarkus.jar.rename> + <disable.quarkus.plugin>true</disable.quarkus.plugin> Review Comment: @yesamer With this PR, the quarkus plugin configuration is inherited everywhere from quarkus parent bom. Those two properties are needed to: 1. enable/disable the jar renaming 2. enable/disable the plugin itself (there are quarkus modules, like this one, inside which the quarkus plugin should not be executed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
