nrknithin commented on code in PR #2244:
URL:
https://github.com/apache/incubator-kie-examples/pull/2244#discussion_r3895083643
##########
kogito-quarkus-examples/kogito-travel-agency/extended/pom.xml:
##########
@@ -35,20 +35,9 @@
<module>visas</module>
</modules>
<properties>
- <quarkus-plugin.version>3.27.5.1</quarkus-plugin.version>
- <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
- <quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
- <quarkus.platform.version>3.27.5.1</quarkus.platform.version>
</properties>
<dependencyManagement>
<dependencies>
- <dependency>
- <groupId>${quarkus.platform.group-id}</groupId>
- <artifactId>${quarkus.platform.artifact-id}</artifactId>
- <version>${quarkus.platform.version}</version>
- <type>pom</type>
- <scope>import</scope>
- </dependency>
</dependencies>
</dependencyManagement>
Review Comment:
Removed here too, along with the same empty blocks in
onboarding-example/payroll/pom.xml.
##########
kogito-springboot-examples/pom.xml:
##########
@@ -154,9 +269,222 @@
<pluginManagement>
<plugins>
<plugin>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-maven-plugin</artifactId>
- <version>${version.org.springframework.boot}</version>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <version>2.5</version>
Review Comment:
Agreed. Worth noting the 2.5 was already hardcoded in the old examples root
pom — this PR only moved the block — but since we now inherit from the kie BOM
chain, ${version.resources.plugin} (3.1.0) resolves fine. Applied it here and
in kogito-quarkus-examples/pom.xml, which had the same hardcode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
